Remove information about the environment from exception when reverting VM snapshot #9944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I am not sure if and how many testing we would need for this, only the textual contents of an exception message has changed and that contents is still available in the log. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #9944 +/- ##
============================================
- Coverage 15.80% 15.80% -0.01%
Complexity 12586 12586
============================================
Files 5627 5627
Lines 492328 492341 +13
Branches 59692 59693 +1
============================================
Hits 77828 77828
- Misses 405977 405990 +13
Partials 8523 8523
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
JoaoJandre
approved these changes
Nov 26, 2024
dhslove
pushed a commit
to ablecloud-team/ablestack-cloud
that referenced
this pull request
Dec 12, 2024
…hot (apache#9944) Co-authored-by: Lucas Martins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When attempting to revert a VM to a VM snapshot, the exception displayed to users can expose some information about the environment.
This PR addresses this issue by keeping the current message to be sent to the logs and adding a new one for the exception shown to users.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Screenshots (if appropriate):
How Has This Been Tested?
I forced a
CloudRuntimeExceptionwhen reverting a VM to a VM snapshot and the new exception was thrown as expected. Then I checked that the current message was still being added to the logs.